Hey Lars,
do you mean Issue #85 on onefinity-firmware?
Note that if you want to contribute code, it is best to provide it in unified diff format:
--- lars1.txt<->2023-11-15 12:51:03.782044763 +0100
+++ lars2.txt<->2023-11-15 12:51:25.438099881 +0100
@@ -1,15 +1,18 @@
+const xSafeProbeOffset = 20 + cutterDiameterMetric / 2.0;
+const ySafeProbeOffset = 20 + cutterDiameterMetric / 2.0;
+
G91 G0 Z ${zLift}
-G91 G0 X 20
+G91 G0 X ${xSafeProbeOffset}
G91 G0 Z ${-plunge}
-G38.2 X -20 F${fastSeek}
+G38.2 X -${xSafeProbeOffset} F${fastSeek}
G91 G1 X 1
G38.2 X -2 F${slowSeek}
G92 X ${xOffset}
.
G91 G0 X 1
-G91 G0 Y 20
-G91 G0 X -20
-G38.2 Y -20 F${fastSeek}
+G91 G0 Y ${ySafeProbeOffset}
+G91 G0 X -${xSafeProbeOffset}
+G38.2 Y -${ySafeProbeOffset} F${fastSeek}
G91 G1 Y 1
G38.2 Y -2 F${slowSeek}
G92 Y ${yOffset}
The reason is that such a diff file can be applied to the source code with patch directly.
Also you’ll have to mention the file name in the source to which your proposed change should apply. In unified diff format, it is added automatically, I used “lars1.txt” and “lars2.txt” because you did not give any filename.
Also I believe OnefinityCNC expects bug reports or enhancement propositions rather under Firmware (Buildbotics) in the forum, than on onefinity-firmware/issues on their github.com repository. At least the few number of filed issues there leads to that impression.
This is of course different if you want to contribute to upstream buildbotics/bbctrl-firmware, where buildbotics/bbctrl-firmware/issues is the right place. They also have a forum though. See here for the main developer on building buildbotics from the sources.
By the way, are you referring to probing with a surfacing bit? Using the Three-axis Touch Plate and the ‘Probe XYZ’ algorithm on Jog Pane with a large surfacing bit or a V-bit is not possible. See here.
Besides of that, taking into account the bit diameter to adjust probe offset makes the procedure smarter 